Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Screenshot" button is poorly integrated #51

Open
JayFoxRox opened this issue Oct 4, 2019 · 0 comments
Open

"Screenshot" button is poorly integrated #51

JayFoxRox opened this issue Oct 4, 2019 · 0 comments

Comments

@JayFoxRox
Copy link
Member

I think we should remove the "Screenshot" button - most operating systems have a feature for this built-in anyway (example: Alt+PrtSc on Windows puts screenshot of active Window in clipboard).

Having support for taking screenshots can potentially be useful for telemetry or bug reports, but this would need better integration.

Issues with the current implementation:

  • A standalone screenshot feature feels unnecessary to me.
  • Button is always shown, even when XQEMU is not even running.
  • There's no confirmation that a screenshot was taken.
  • The user does not know where the file is saved.
  • Only a single screenshot file (screenshot.ppm) is allowed.
  • PPM is not widely supported, especially in browsers, so screenshots can not be shared too easily.

I think we should remove the button for now to avoid all of these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant