Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 8 target #82

Closed
lilith opened this issue Jan 31, 2024 · 3 comments
Closed

Add .NET 8 target #82

lilith opened this issue Jan 31, 2024 · 3 comments

Comments

@lilith
Copy link
Contributor

lilith commented Jan 31, 2024

Suggesting adding a .NET 8 target to the core and test projects and to CI.

We could also consider adding an ubuntu-latest test to the matrix? It's not like the library does much OS integration, but OS pivots are common in the ecosystem and some future day it might be helpful. ubuntu might also complete faster.

Other considerations: .NET 7 EOL is May 14, 2024

We have a few .NET 6 ifdefs with additional DateOnly etc type support, and .NET 6 isn't EOL until Nov 12.
Perhaps the targets should be .NET 6 & 8 to avoid breaking that type for .NET 7 users?

@lilith
Copy link
Contributor Author

lilith commented Feb 1, 2024

I've added this to #79. I noticed that the library was not being tested against any .NET Standard 2.0 platform, so I added a conditional net48 target for the unit tests and added ubuntu to the ci matrix

@lilith
Copy link
Contributor Author

lilith commented Feb 1, 2024

The CI is now working for me on my fork, so it should be ready to merge if this is the directly you want to go (6+8+.Net Standard 2), test (ubuntu + windows) x (6, 8, net48)

xoofx added a commit that referenced this issue Feb 1, 2024
@xoofx
Copy link
Owner

xoofx commented Feb 1, 2024

Fixed by #81

Perhaps the targets should be .NET 6 & 8 to avoid breaking that type for .NET 7 users?
The CI is now working for me on my fork, so it should be ready to merge if this is the directly you want to go (6+8+.Net Standard 2), test (ubuntu + windows) x (6, 8, net48)

Yeah, let's try net6.0 and net8.0 and see how it goes. Don't have a strong opinion on it.

@xoofx xoofx closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants