From 1b3745031c403d6a85f3784b73f2805fdf188f86 Mon Sep 17 00:00:00 2001 From: Alex Risch Date: Mon, 18 Dec 2023 15:11:33 -0700 Subject: [PATCH] Remove Manual Install Step Problem: There are a number of manual steps required when integrating with React Native SDK Would like to make sure that this is indeed a requirement or if we can smooth out integration steps Solution: Move dependency to podspec Remove ReadMe step --- README.md | 1 - example/ios/Podfile | 2 -- ios/XMTPReactNative.podspec | 1 + 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/README.md b/README.md index 9085d3151..c1a6ba12f 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,6 @@ yarn i @xmtp/react-native-sdk In the `ios` directory, update your `Podfile` file as follows: - Set this value: `platform :ios, '16.0'`. This is required by XMTP. -- Add this line: `pod 'secp256k1.swift', :modular_headers => true`. This is required for web3.swift. ```bash npx pod-install diff --git a/example/ios/Podfile b/example/ios/Podfile index d81044f0f..07b274a5c 100644 --- a/example/ios/Podfile +++ b/example/ios/Podfile @@ -48,8 +48,6 @@ target 'xmtpreactnativesdkexample' do # Flags change depending on the env values. flags = get_default_flags() - pod 'secp256k1.swift', :modular_headers => true - use_react_native!( :path => config[:reactNativePath], :hermes_enabled => podfile_properties['expo.jsEngine'] == nil || podfile_properties['expo.jsEngine'] == 'hermes', diff --git a/ios/XMTPReactNative.podspec b/ios/XMTPReactNative.podspec index 88246e716..95568074f 100644 --- a/ios/XMTPReactNative.podspec +++ b/ios/XMTPReactNative.podspec @@ -24,6 +24,7 @@ Pod::Spec.new do |s| } s.source_files = "**/*.{h,m,swift}" + s.dependency 'secp256k1.swift' s.dependency "MessagePacker" s.dependency "XMTP", "= 0.7.3-alpha0" end