Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board set-up functions should report a fail rather than hang forever #20

Closed
xross opened this issue Oct 1, 2024 · 2 comments
Closed

Comments

@xross
Copy link
Contributor

xross commented Oct 1, 2024

If a user runs a project on a custom board it would be nice if the project didn't hang forever on an I2S access.

Instead the func should return error.

Even a trip my be more beneficial to e developer than a hang.

Note, the code appears to be trying to the right thing, but if using Lib_i2c with nothing attached (i.e. no pull up) then lib_i2c will hang forever...

@xross
Copy link
Contributor Author

xross commented Oct 1, 2024

On reflection, the "real" fix is likely in lib_i2c. Adding a timeout or checking for pull-up etc.

@xross
Copy link
Contributor Author

xross commented Oct 1, 2024

xmos/lib_i2c#97

@xross xross closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant