Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WIP, to open discussion)
The only value that can be modified, once the keymap is compiled, is the reference counter. Use atomics to make it thread-safe.
WARNING: this alone does not make the keymap API thread-safe:
xkb_context
for its strings values; this table is not thread-safe.However it is “safe” only if no other keymap is compiled using the same context.
xkb_context
internal string buffer, which is not thread safe.API not using this buffer should be “safe”.
xkb_context
log function, but modifying it is not thread-safe.Fixes #300