state: add API for updating latched and locked mods & layout in server state #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
enhancement
wismill
force-pushed
the
state/update-latched-locked
branch
from
d7b0c3d to
b1855fa
Compare
Up to now, the “server state” `xkb_state` API only offered one entry point to update the server state – `xkb_state_update_key`, which reflects the direct keyboard keys state. But some updates come out-of-band from keyboard input events stream, for example, a GUI layout switcher. The X11 XKB protocol has a request which allows for such updates, `XkbLatchLockState`[^1], but xkbcommon does not have similar functionality. So server applications ended up using `xkb_state_update_state` for this, but that’s a function intended for client applications, not servers. Add support for updating the latched & locked state of the mods and layout. Note that the depressed states cannot be updated in this way -- XKB does not expect them to be updated out of band. [^1]: https://www.x.org/releases/X11R7.7/doc/kbproto/xkbproto.html#Querying_and_Changing_Keyboard_State Fixes: xkbcommon#310 Signed-off-by: Ran Benita <[email protected]> Co-authored-by: Ran Benita <[email protected]> Co-authored-by: Pierre Le Marre <[email protected]>
wismill
force-pushed
the
state/update-latched-locked
branch
from
b1855fa to
01b64bb
Compare
|
Rebased and fixed latch-to-lock clearance side-effects. |
|
Refactored tests, added lots of new tests and fix numerous edges cases. This is much more tricky than expected, so the tests are crucial. We should probably also try some random config à la QuickCheck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Revival of #314)
Up to now, the “server state”
xkb_state`` API only offered one entry point to update the server state -xkb_state_update_key`, which reflects the direct keyboard keys state. But some updates come out-of-band from keyboard input events stream, for example, a GUI layout switcher.The X11 XKB protocol has a request which allows for such updates,
XkbLatchLockState1, but xkbcommon does not have similar functionality. So server applications ended up usingxkb_state_update_statefor this, but that’s a function intended for client applications, not servers.Add support for updating the latched & locked state of the mods and layout. Note that the depressed states cannot be updated in this way -- XKB does not expect them to be updated out of band.
Fixes: #310
Footnotes
https://www.x.org/releases/X11R7.7/doc/kbproto/xkbproto.html#Querying_and_Changing_Keyboard_State ↩