Enable out-of-range group action configuration using options API (take 3) #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new keymap compile options API: - `xkb_keymap_compile_options_new` - `xkb_keymap_compile_options_free` - `xkb_keymap_new_from_names2` - `xkb_keymap_new_from_file2` - `xkb_keymap_new_from_buffer2` This interface allows to configure keymap options that cannot be passed as flags.
Enable the configuration of out-of-range layout handling using the new function `xkb_keymap_compile_options_set_layout_out_of_range_action` and the corresponding new enumeration `xkb_keymap_out_of_range_layout_action`: - `XKB_KEYMAP_WRAP_OUT_OF_RANGE_LAYOUT`: wrap into range using integer modulus (default, as before). - `XKB_KEYMAP_REDIRECT_OUT_OF_RANGE_LAYOUT`: redirect to a specific layout index. - `XKB_KEYMAP_CLAMP_OUT_OF_RANGE_LAYOUT`: clamp into range, i.e. invalid indexes are corrected to the closest valid bound (0 or highest layout index). When not specified, invalid groups are brought into range using integer modulus.
wismill
force-pushed
the
keymap/out-of-range-group-action3
branch
from
58348ec to
0a0876f
Compare
This was referenced Sep 28, 2024
wismill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #487 I added keymap compile flags to configure the out-of-range group action, but it should be separate PR.
Note that I proposed previously:
xkb_keymap“immutable”.My (hopefully) last proposal is to introduce a keymap compile options API. This will give us also more flexibility to introduce options that cannot (or not easily) be configured by flags.
TODO: