Overlays #514
Draft
Overlays #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
X11 legacy: missing feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rough implementation of overlays. It works but requires more tests.
However, I am not sure what API to propose. This is messing with the keycodes and thus requires extreme rigor for the compositor. We could try to make it completely internal and then provide no keycode redirection in the API.
I think permanent overlays could be however really useful and completely internal: we would just copy the target key into the source key, thus making easy to permute keys. Not exactly the implementation in X11, but same effect apart the keycodes changes.
I am not planning to work further on general overlays ATM, but I share this to open discussion.
Fixes #124