Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag display layout is slightly distorted on Android Chrome #236

Open
yasuking0304 opened this issue Oct 22, 2024 · 1 comment
Open

Tag display layout is slightly distorted on Android Chrome #236

yasuking0304 opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@yasuking0304
Copy link

yasuking0304 commented Oct 22, 2024

The problem

Tag display layout is slightly distorted on Android Chrome.

Release version

Latest

Operating system

Windows
Chome
Windows
Edge(Chomium)
Windows
Firefox
MacOS
Safari
MacOS
Chome
iPadOS
Safari
iPhone
Safari
Android
Chome
Android
Samsung Brower(Chromium)
No Problem No Problem No Problem No Problem No Problem No Problem No Problem NG NG

Steps to reproduce the behavior

None

Log files

No response

Screenshots

Android Chrome(Remote debuggiing)
WS000056

Additional context

The system font set is not specified properly.

This can be resolved by adding the following system font specification:

https://github.com/xicri/genshin-dictionary/blob/main/assets/styles/global.scss#L3-L4

html {
  font-family: "Noto Sans CJK JP", "Meiryo", "Hiragino Sans", sans-serif;

html {
  font-family: system-ui, -apple-system, "Noto Sans CJK JP", "Meiryo", "Hiragino Sans", sans-serif;

WS000057

@xicri xicri self-assigned this Oct 23, 2024
@xicri xicri added the bug Something isn't working label Oct 23, 2024
@yasuking0304
Copy link
Author

I checked it when I had time, and it seems that android chrome and sans-serif don't work well together.

Also, if you put system-ui at the top, Meiryo UI seems to be used as the Windows font, which isn't very good.

WS000091

As a result, it seems best to put "system-ui" and "-apple-system" before "sans-serif".
https://github.com/xicri/genshin-dictionary/blob/main/assets/styles/global.scss#L3-L4

html {
  font-family: "Noto Sans CJK JP", "Meiryo", "Hiragino Sans", sans-serif;

html {
  font-family: "Noto Sans CJK JP", "Meiryo", "Hiragino Sans", system-ui, -apple-system, sans-serif;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants