Skip to content

Commit

Permalink
Revert "kernel: Adapt to low version Android init process (tiann#973)"
Browse files Browse the repository at this point in the history
This reverts commit 54ee400.
  • Loading branch information
xiangfeidexiaohuo committed Jan 6, 2024
1 parent 1fad91a commit 69a1762
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 84 deletions.
2 changes: 1 addition & 1 deletion kernel/allowlist.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ void ksu_show_allow_list(void)
{
struct perm_data *p = NULL;
struct list_head *pos = NULL;
pr_info("ksu_show_allow_list\n");
pr_info("ksu_show_allow_list");
list_for_each (pos, &allow_list) {
p = list_entry(pos, struct perm_data, list);
pr_info("uid :%d, allow: %d\n", p->profile.current_uid,
Expand Down
4 changes: 2 additions & 2 deletions kernel/apk_sign.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ static __always_inline bool check_v2_signature(char *path,
int i;
struct file *fp = ksu_filp_open_compat(path, O_RDONLY, 0);
if (IS_ERR(fp)) {
pr_err("open %s error.\n", path);
pr_err("open %s error.", path);
return PTR_ERR(fp);
}

Expand Down Expand Up @@ -291,7 +291,7 @@ static int set_expected_size(const char *val, const struct kernel_param *kp)
{
int rv = param_set_uint(val, kp);
ksu_invalidate_manager_uid();
pr_info("ksu_expected_size set to %x\n", ksu_expected_size);
pr_info("ksu_expected_size set to %x", ksu_expected_size);
return rv;
}

Expand Down
8 changes: 4 additions & 4 deletions kernel/core_hook.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ int ksu_handle_rename(struct dentry *old_dentry, struct dentry *new_dentry)
if (strcmp(buf, "/system/packages.list")) {
return 0;
}
pr_info("renameat: %s -> %s, new path: %s\n", old_dentry->d_iname,
pr_info("renameat: %s -> %s, new path: %s", old_dentry->d_iname,
new_dentry->d_iname, buf);

update_uid();
Expand Down Expand Up @@ -318,7 +318,7 @@ int ksu_handle_prctl(int option, unsigned long arg2, unsigned long arg3,
static bool post_fs_data_lock = false;
if (!post_fs_data_lock) {
post_fs_data_lock = true;
pr_info("post-fs-data triggered\n");
pr_info("post-fs-data triggered");
on_post_fs_data();
}
break;
Expand All @@ -327,7 +327,7 @@ int ksu_handle_prctl(int option, unsigned long arg2, unsigned long arg3,
static bool boot_complete_lock = false;
if (!boot_complete_lock) {
boot_complete_lock = true;
pr_info("boot_complete triggered\n");
pr_info("boot_complete triggered");
}
break;
}
Expand Down Expand Up @@ -669,7 +669,7 @@ static int ksu_key_permission(key_ref_t key_ref, const struct cred *cred,
return 0;
}
init_session_keyring = cred->session_keyring;
pr_info("kernel_compat: got init_session_keyring\n");
pr_info("kernel_compat: got init_session_keyring");
return 0;
}
#endif
Expand Down
74 changes: 7 additions & 67 deletions kernel/ksud.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ void on_post_fs_data(void)
{
static bool done = false;
if (done) {
pr_info("on_post_fs_data already done\n");
pr_info("on_post_fs_data already done");
return;
}
done = true;
pr_info("on_post_fs_data!\n");
pr_info("on_post_fs_data!");
ksu_load_allow_list();
// sanity check, this may influence the performance
stop_input_hook();
Expand Down Expand Up @@ -151,11 +151,7 @@ int ksu_handle_execveat_ksud(int *fd, struct filename **filename_ptr,

static const char app_process[] = "/system/bin/app_process";
static bool first_app_process = true;

/* This applies to versions Android 10+ */
static const char system_bin_init[] = "/system/bin/init";
/* This applies to versions between Android 6 ~ 9 */
static const char old_system_init[] = "/init";
static bool init_second_stage_executed = false;

if (!filename_ptr)
Expand All @@ -175,8 +171,8 @@ int ksu_handle_execveat_ksud(int *fd, struct filename **filename_ptr,
const char __user *p = get_user_arg_ptr(*argv, 1);
if (p && !IS_ERR(p)) {
char first_arg[16];
ksu_strncpy_from_user_nofault(first_arg, p, sizeof(first_arg));
pr_info("/system/bin/init first arg: %s\n", first_arg);
ksu_strncpy_from_user_nofault(first_arg, p, sizeof(first_arg));
pr_info("first arg: %s\n", first_arg);
if (!strcmp(first_arg, "second_stage")) {
pr_info("/system/bin/init second_stage executed\n");
apply_kernelsu_rules();
Expand All @@ -187,63 +183,10 @@ int ksu_handle_execveat_ksud(int *fd, struct filename **filename_ptr,
pr_err("/system/bin/init parse args err!\n");
}
}
} else if (unlikely(!memcmp(filename->name, old_system_init,
sizeof(old_system_init) - 1) && argv)) {
// /init executed
int argc = count(*argv, MAX_ARG_STRINGS);
pr_info("/init argc: %d\n", argc);
if (argc > 1 && !init_second_stage_executed) {
/* This applies to versions between Android 6 ~ 7 */
const char __user *p = get_user_arg_ptr(*argv, 1);
if (p && !IS_ERR(p)) {
char first_arg[16];
ksu_strncpy_from_user_nofault(first_arg, p, sizeof(first_arg));
pr_info("/init first arg: %s\n", first_arg);
if (!strcmp(first_arg, "--second-stage")) {
pr_info("/init second_stage executed\n");
apply_kernelsu_rules();
init_second_stage_executed = true;
ksu_android_ns_fs_check();
}
} else {
pr_err("/init parse args err!\n");
}
} else if (argc == 1 && !init_second_stage_executed && envp) {
/* This applies to versions between Android 8 ~ 9 */
int envc = count(*envp, MAX_ARG_STRINGS);
if (envc > 0) {
int n;
for (n = 1; n <= envc; n++) {
const char __user *p = get_user_arg_ptr(*envp, n);
if (!p || IS_ERR(p)) {
continue;
}
char env[256];
// Reading environment variable strings from user space
if (ksu_strncpy_from_user_nofault(env, p, sizeof(env)) < 0)
continue;
// Parsing environment variable names and values
char *env_name = env;
char *env_value = strchr(env, '=');
if (env_value == NULL)
continue;
// Replace equal sign with string terminator
*env_value = '\0';
env_value++;
// Check if the environment variable name and value are matching
if (!strcmp(env_name, "INIT_SECOND_STAGE") && (!strcmp(env_value, "1") || !strcmp(env_value, "true"))) {
pr_info("/init second_stage executed\n");
apply_kernelsu_rules();
init_second_stage_executed = true;
ksu_android_ns_fs_check();
}
}
}
}
}

if (unlikely(first_app_process &&
!memcmp(filename->name, app_process, sizeof(app_process) - 1))) {
!memcmp(filename->name, app_process, sizeof(app_process) - 1))) {
first_app_process = false;
pr_info("exec app_process, /data prepared, second_stage: %d\n", init_second_stage_executed);
on_post_fs_data(); // we keep this for old ksud
Expand All @@ -264,7 +207,7 @@ static ssize_t read_proxy(struct file *file, char __user *buf, size_t count,
bool first_read = file->f_pos == 0;
ssize_t ret = orig_read(file, buf, count, pos);
if (first_read) {
pr_info("read_proxy append %ld + %ld\n", ret, read_count_append);
pr_info("read_proxy append %ld + %ld", ret, read_count_append);
ret += read_count_append;
}
return ret;
Expand All @@ -275,7 +218,7 @@ static ssize_t read_iter_proxy(struct kiocb *iocb, struct iov_iter *to)
bool first_read = iocb->ki_pos == 0;
ssize_t ret = orig_read_iter(iocb, to);
if (first_read) {
pr_info("read_iter_proxy append %ld + %ld\n", ret,
pr_info("read_iter_proxy append %ld + %ld", ret,
read_count_append);
ret += read_count_append;
}
Expand Down Expand Up @@ -514,7 +457,6 @@ static void stop_vfs_read_hook()
pr_info("unregister vfs_read kprobe: %d!\n", ret);
#else
ksu_vfs_read_hook = false;
pr_info("stop vfs_read_hook\n");
#endif
}

Expand All @@ -525,7 +467,6 @@ static void stop_execve_hook()
pr_info("unregister execve kprobe: %d!\n", ret);
#else
ksu_execveat_hook = false;
pr_info("stop execve_hook\n");
#endif
}

Expand All @@ -541,7 +482,6 @@ static void stop_input_hook()
pr_info("unregister input kprobe: %d!\n", ret);
#else
ksu_input_hook = false;
pr_info("stop input_hook\n");
#endif
}

Expand Down
4 changes: 2 additions & 2 deletions kernel/manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ bool become_manager(char *pkg)
continue;
}
// we have found the apk!
pr_info("found apk: %s\n", cwd);
pr_info("found apk: %s", cwd);
char *pkg_index = strstr(cwd, pkg);
if (!pkg_index) {
pr_info("apk path not match package name!\n");
Expand Down Expand Up @@ -90,7 +90,7 @@ bool become_manager(char *pkg)
result = true;
goto clean;
} else {
pr_info("manager signature invalid!\n");
pr_info("manager signature invalid!");
}

break;
Expand Down
10 changes: 5 additions & 5 deletions kernel/selinux/rules.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static struct policydb *get_policydb(void)
void apply_kernelsu_rules()
{
if (!getenforce()) {
pr_info("SELinux permissive or disabled, apply rules!\n");
pr_info("SELinux permissive or disabled, apply rules!");
}

rcu_read_lock();
Expand Down Expand Up @@ -253,7 +253,7 @@ int handle_sepolicy(unsigned long arg3, void __user *arg4)
} else if (subcmd == 4) {
success = ksu_dontaudit(db, s, t, c, p);
} else {
pr_err("sepol: unknown subcmd: %d\n", subcmd);
pr_err("sepol: unknown subcmd: %d", subcmd);
}
ret = success ? 0 : -1;

Expand Down Expand Up @@ -298,7 +298,7 @@ int handle_sepolicy(unsigned long arg3, void __user *arg4)
} else if (subcmd == 3) {
success = ksu_dontauditxperm(db, s, t, c, perm_set);
} else {
pr_err("sepol: unknown subcmd: %d\n", subcmd);
pr_err("sepol: unknown subcmd: %d", subcmd);
}
ret = success ? 0 : -1;
} else if (cmd == CMD_TYPE_STATE) {
Expand All @@ -315,7 +315,7 @@ int handle_sepolicy(unsigned long arg3, void __user *arg4)
} else if (subcmd == 2) {
success = ksu_enforce(db, src);
} else {
pr_err("sepol: unknown subcmd: %d\n", subcmd);
pr_err("sepol: unknown subcmd: %d", subcmd);
}
if (success)
ret = 0;
Expand Down Expand Up @@ -430,7 +430,7 @@ int handle_sepolicy(unsigned long arg3, void __user *arg4)
success = ksu_type_member(db, src, tgt, cls,
default_type);
} else {
pr_err("sepol: unknown subcmd: %d\n", subcmd);
pr_err("sepol: unknown subcmd: %d", subcmd);
}
if (success)
ret = 0;
Expand Down
2 changes: 1 addition & 1 deletion kernel/selinux/selinux.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static int transive_to_domain(const char *domain)
void setup_selinux(const char *domain)
{
if (transive_to_domain(domain)) {
pr_err("transive domain failed.\n");
pr_err("transive domain failed.");
return;
}

Expand Down
4 changes: 2 additions & 2 deletions kernel/selinux/sepolicy.c
Original file line number Diff line number Diff line change
Expand Up @@ -592,14 +592,14 @@ static bool add_filename_trans(struct policydb *db, const char *s,
trans = (struct filename_trans_datum *)kcalloc(sizeof(*trans),
1, GFP_ATOMIC);
if (!trans) {
pr_err("add_filename_trans: Failed to alloc datum\n");
pr_err("add_filename_trans: Failed to alloc datum");
return false;
}
struct filename_trans *new_key =
(struct filename_trans *)kmalloc(sizeof(*new_key),
GFP_ATOMIC);
if (!new_key) {
pr_err("add_filename_trans: Failed to alloc new_key\n");
pr_err("add_filename_trans: Failed to alloc new_key");
return false;
}
*new_key = key;
Expand Down

0 comments on commit 69a1762

Please sign in to comment.