Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestController updates should more properly be routed via PATCH #266

Open
amcclain opened this issue Sep 6, 2022 · 0 comments
Open

RestController updates should more properly be routed via PATCH #266

amcclain opened this issue Sep 6, 2022 · 0 comments

Comments

@amcclain
Copy link
Member

amcclain commented Sep 6, 2022

The update method of RestController binds any data provided to an existing domain object, which makes it a partial update. The corresponding HTTP method should be PATCH, but we instead expect PUT.

See https://www.geeksforgeeks.org/difference-between-put-and-patch-request for one reference.

We should consider a) non-breaking change to start supporting PATCH, then possibly b) breaking change to either remove PUT support or make PUT act as a true PUT, replacing or creating the object in its entirety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant