Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sep argument not working multilayer plotting function #433

Closed
maximelucas opened this issue Jul 27, 2023 · 6 comments · Fixed by #476
Closed

sep argument not working multilayer plotting function #433

maximelucas opened this issue Jul 27, 2023 · 6 comments · Fixed by #476
Assignees
Labels

Comments

@maximelucas
Copy link
Collaborator

It seems to have no effect

@thomasrobiglio
Copy link
Collaborator

uhm I will have a look at it! thank you @maximelucas

@thomasrobiglio thomasrobiglio self-assigned this Jul 27, 2023
@nwlandry
Copy link
Collaborator

Hi @thomasrobiglio - I started adding some features to draw_multilayer - can I push this first?

@thomasrobiglio
Copy link
Collaborator

Yes sure!

@thomasrobiglio
Copy link
Collaborator

Hi @maximelucas, I am reviewing the upgrades to the multilayer drawing in #434 by @nwlandry. The sep arguments is working fine... I think that the issue might be that sep that it has an interplay with the dimension
of the picture set with the height paramenter: if I have a small picture I can only set the separation between the planes up to a certain value, then I will not see any changes because the size of the image is bound. Maybe we should document it better? Or just show how it works in the new viz tutorials?

Below some examples of the sep parameter working 😄

Screenshot 2023-08-03 alle 17 38 59 Screenshot 2023-08-03 alle 17 39 14

@maximelucas
Copy link
Collaborator Author

Okay nice :) This is with the new version?
Then maybe just document this yes. Could even be nice to give a rough idea/example of when it starts not having an effect.

@thomasrobiglio
Copy link
Collaborator

This is with the new version?

Yes, but it should work the same in the stable version

Could even be nice to give a rough idea/example of when it starts not having an effect.

Good idea, let's keep the issue open and I will work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants