Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Auto model not working #276

Open
3 tasks done
EpicGamer42069Fortnite opened this issue Oct 20, 2023 · 5 comments
Open
3 tasks done

[Bug] Auto model not working #276

EpicGamer42069Fortnite opened this issue Oct 20, 2023 · 5 comments
Labels

Comments

@EpicGamer42069Fortnite
Copy link

Describe the bug

Models do not convert automatically from wide to slim.

Steps to reproduce

1. In the config, have the model option set to "auto".
2. Set your launcher skin to a wide skin.
3. Set your "CustomSkinLoader" skin to a slim skin.
4. The skin doesn't convert to slim skin in-game.

Link to crash-report if applicable

No response

Link to CustomSkinLoader.log if applicable

No response

Link to latest.log if applicable

No response

[Only Forge User] Link to Forge Log if applicable

No response

Mod Version

14.18 - 14.18.3-SNAPSHOT-27

Minecraft Version

1.20.1

Minecraft Launcher Name and Version

Vanilla Launcher

Mod Loader

Fabric

Operating System

Windows

Before submitting a bug report

  • This bug wasn't already reported (I have searched bug reports on GitHub).

  • This is a valid bug (I am able to reproduce this on the latest dev build).

  • This problem is triggered in the latest version of the mod (if not the latest please upgrade the mod first)

@xfl03
Copy link
Owner

xfl03 commented Dec 4, 2023

Skin will not be converted. The model used in game will follow the skin origin model.

@xfl03 xfl03 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
@xfl03 xfl03 added invalid and removed bug labels Dec 4, 2023
@8MiYile
Copy link
Contributor

8MiYile commented Dec 5, 2023

Skin files are what they are, we don't automatically edit them.

@EpicGamer42069Fortnite
Copy link
Author

EpicGamer42069Fortnite commented Dec 10, 2023

This is what I'm trying to say:

In older versions of the mod, if I had my Minecraft Launcher model set to wide, and my CustomSkinLoader skin is a slim skin, and the model inside the config file set to auto, my player model would automatically change to slim once I load the game, which is correct.

In newer versions of the mod, my model stays as a wide model, even though I put a slim skin inside the CustomSkinLoader folder.

Sorry for the confusion, let me know if you need me to clarify more.

@ZekerZhayard ZekerZhayard reopened this Dec 10, 2023
@ZekerZhayard
Copy link
Collaborator

Thanks for your feedback. I rechecked the code. Since Mojang changed some of the code related to skin loading after 23w31a, the module's original code was not working. This will be fixed as soon as possible.

@xfl03 xfl03 added bug and removed invalid labels Dec 11, 2023
@Tartilla-TAIGO
Copy link

This bug is also observed in 1.19.3. Is there a way to fix it, or is it necessary to wait for a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants