Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate duplicate tc-loader scripts #9

Open
tohojo opened this issue Jan 26, 2021 · 5 comments
Open

Consolidate duplicate tc-loader scripts #9

tohojo opened this issue Jan 26, 2021 · 5 comments
Assignees

Comments

@tohojo
Copy link
Member

tohojo commented Jan 26, 2021

We should probably consolidate the different copies of the TC loader scripts in subdirectories into a single version in a parent/lib directory...

@simosund
Copy link
Contributor

simosund commented Feb 8, 2021

Same thing probably goes for the configure script to detect if iproute has libbpf support.

@tohojo
Copy link
Member Author

tohojo commented Feb 8, 2021

Yeah. IIRC, @netoptimizer expressed a preference for keeping separate configure scripts in each subdir, but they can still share code :)

@simosund
Copy link
Contributor

Worth mentioning that in my current PR I've extended the tc loader script somewhat to support attaching a pinned program (and gotten rid of the configure script).

@netoptimizer
Copy link
Member

As libbpf now support TC-attaching directly, we should consider converting "pping" and "traffic-pacing-edt" to use that instead of mentioned shell script.

@simosund
Copy link
Contributor

simosund commented Jun 3, 2021

Yep, converting pping to use libbpf for attaching the tc program is on my TODO list, so this issue is likely goning to resolve itself that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants