Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning of "unimplemented" constants #4

Open
fizzyduck opened this issue Sep 19, 2021 · 3 comments
Open

Meaning of "unimplemented" constants #4

fizzyduck opened this issue Sep 19, 2021 · 3 comments

Comments

@fizzyduck
Copy link

@xdecock Would you mind explaining what the unimplemented constants below refer to? Some wider context would be really helpful.

#define VMODSEC_TRANS_STATE_INIT = 1;

@xdecock
Copy link
Owner

xdecock commented Sep 1, 2022

Hello, the goal here is to have a fsm with state tracking, i'll need to get back in the middle of the code to be honnest, was coded overnight as a proof of concept, and, i was never sure anybody would use it.

i've just updated the code to compile correctly on varnish 7.

that being said, it might be some left over that are not needed anymore.

the only advantage i see is to only accept certain calls in certain vcl method, it might be useful if the user writing the vcl tries to run methods in bad locations, so it will mainly help have a more defensive vmod.

let me know if this helps. that being said, wrote this a long time ago, i'll need to re-understand the logic

@iammeken
Copy link

iammeken commented Sep 4, 2022

Hello, the goal here is to have a fsm with state tracking, i'll need to get back in the middle of the code to be honnest, was coded overnight as a proof of concept, and, i was never sure anybody would use it.

It is a brilliant idea, you should not give it up.

@iammeken
Copy link

iammeken commented Sep 4, 2022

The libModSecurity design allows the integration with bindings. There is an effort to avoid breaking API [binary] compatibility to make an easy integration with possible bindings. Currently, there are two notable projects maintained by the community:

Python - https://github.com/actions-security/pymodsecurity
Varnish - https://github.com/xdecock/vmod-modsecurity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants