Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context popup menu far from the mouse #17

Open
dandv opened this issue Jun 3, 2015 · 4 comments
Open

Context popup menu far from the mouse #17

dandv opened this issue Jun 3, 2015 · 4 comments

Comments

@dandv
Copy link

dandv commented Jun 3, 2015

When you select downward text that comprises multiple lines, the Y coordinate of the context menu is at the beginning of the selection. The X is correct.

@molily's component doesn't suffer from this problem (demo).

context popup menu far from the mouse

@dandv
Copy link
Author

dandv commented Jun 3, 2015

Fixed in my fork of SelectionMenu that addresses a few other issues from selection-sharer and makes it general (i.e you can put anything you want in the menu).

@xdamman
Copy link
Owner

xdamman commented Jun 23, 2015

@dandv can you submit a pull request so that everybody can benefit from it? Thanks!

@dandv
Copy link
Author

dandv commented Jul 30, 2015

@xdamman: in the meantime our fork evolved quite radically by using HubSpot's Drop library (which prevents #20 in selection-sharer).

Perhaps it's best we continue efforts in that direction?

@q2apro
Copy link

q2apro commented Jul 13, 2017

I think it is smarter to show the menu directly where the mouse was released.

Change line 148

var top = topOffset + self.getPosition().y - self.$popover.height();

to:

var top = e.pageY - self.$popover.height() - 10;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants