-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context popup menu far from the mouse #17
Comments
Fixed in my fork of SelectionMenu that addresses a few other issues from selection-sharer and makes it general (i.e you can put anything you want in the menu). |
@dandv can you submit a pull request so that everybody can benefit from it? Thanks! |
@xdamman: in the meantime our fork evolved quite radically by using HubSpot's Drop library (which prevents #20 in selection-sharer). Perhaps it's best we continue efforts in that direction? |
I think it is smarter to show the menu directly where the mouse was released. Change line 148
to:
|
When you select downward text that comprises multiple lines, the Y coordinate of the context menu is at the beginning of the selection. The X is correct.
@molily's component doesn't suffer from this problem (demo).
The text was updated successfully, but these errors were encountered: