Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed RAR files won't ask before they start to unpack. #87

Open
Sopor opened this issue Apr 29, 2020 · 5 comments
Open

Compressed RAR files won't ask before they start to unpack. #87

Sopor opened this issue Apr 29, 2020 · 5 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Apr 29, 2020

It seems that when a RAR archive is compressed Kodi will not ask if it should extract the file or not. It will start to extract it without asking. If i press on a compressed RAR archive (BluRay ISO file) it will extract the whole file to my Vero 4K. Both Vero and RPi have 100 mbit (older ones) and it won't even fit a full sized BD ISO that can be as big as 48GB. Even a DVD or mkv (4GB) will take forever to extract at 100 mbit.

Kodi 17.6 (and earlier as far as i can remember) will show a message and ask you if it should unpack big file.

I don't know if this is a vfs.rar issue or Kodi, but it really needs to be re-added, so the user can choose if it should unpack it or not.

image

@Sopor
Copy link
Contributor Author

Sopor commented Apr 29, 2020

Update:
If the file is compressed it should not show the mkv file (this is to show that the file is not STORED). Instead the first RAR file should be shown (from Kodi 17.6):

image

As i mentioned before, it should ask if it should unpack it (from Kodi 17.6):

image

@AlwinEsch
Copy link
Member

Thanks for report.
I know this problem, just didn't think about it anymore, will look the next time to find a solution there, problems with dialogs currently is to separate between user ask and background processes (e.g. the old issue after I added the password dialog, where showed 100... times dialog).

Will then look closely like Kodi 17.6, it did when RAR support was still in it.

@AlwinEsch
Copy link
Member

About this becomes the dialog added here #92 and after them done also on Leia.

@Sopor
Copy link
Contributor Author

Sopor commented Oct 3, 2020

@AlwinEsch There is still one issue with this Need to unpack big files. Continue? dialog. It will popup when i entering the folder, so i don't know if it is the video file or the subs file that is needed to be unpacked. It should tell me what kind of file it is about to unpack.

Here is the dialog in Kodi 18.8:
image

Here is the exact same directory but it is from Kodi 17.8:
image

As you can see it shows what kind of file it is (in this case a sub file) and then i know this is a subtitle file and i can press yes to unpack it.

I took an mkv file and use compression on it and in Kodi 17.8 it will show up as an mkv file:
image

But in Kodi 18.8 it will show the rar file in the dialog even if it is the mkv file i try to run:
image

@ZevZev
Copy link

ZevZev commented Apr 26, 2021

Same issue for me in Kodi v19 with vfs.rar v4.0 - on Windows 10. I tried to use libarchive as a replacement - but that never worked well for me - neither in Kodi 18 or now in 19. With libarchive installed scanning my library takes forever - and, I can't seem to play videos in RAR files with it. It only seems to work with vfs.rar for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants