CA-397599 XSI-1704 implement setter for blocked ops manually #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport ada0dc7 Currently the setter for field VM.blocked_oeprations is auto generated. Implement this explicitly such that we can update allowed operations which currently is not happening. Allowed operations are used by XenCenter to disable operations; this has led to operations becoming unavaliable because allowed operations where not aligned with blocked operations when blocked operations were updated. Signed-off-by: Christian Lindig <[email protected]>
Vincent-lau
approved these changes
Sep 16, 2024
| @@ -1659,6 +1659,15 @@ let set_domain_type ~__context ~self ~value = | |||
| Db.VM.set_HVM_boot_policy ~__context ~self | |||
| ~value:(derive_hvm_boot_policy ~domain_type:value) | |||
|
|
|||
| let set_blocked_operations ~__context ~self ~value = | |||
| Db.VM.set_blocked_operations ~__context ~self ~value | |||
There was a problem hiding this comment.
No need for debug "%s" __FUNCTION__ here?
There was a problem hiding this comment.
__FUNCTION__ is not available in OCaml 4.08, it's also good for debugging, which is less of a need now that the patch has been tested in the master version
There was a problem hiding this comment.
Removed them; the logs in message forwarding should be enough.
psafont
approved these changes
Sep 16, 2024
Signed-off-by: Christian Lindig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ada0dc7
Currently the setter for field VM.blocked_oeprations is auto generated. Implement this explicitly such that we can update allowed operations which currently is not happening. Allowed operations are used by XenCenter to disable operations; this has led to operations becoming unavaliable because allowed operations where not aligned with blocked operations when blocked operations were updated.