-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA-389496: Avoid conflicts in configuration for rotating xapi logs #5507
Conversation
@rosslagerwall you might want to review this |
Manual testing shows that logrotation on size reached happens correctly, and no loss is observed. I'm double-checking the update case |
I've tested the following update cases:
And
A robust solution for the second case is needed before taking the fix |
This should already be set in |
The second scenario will get taken care of in the .spec as a post-install procedure |
The kill -HUP also seems suspect as well, but I'm seeing that in many of the logrotate configuration files (with rsyslogd.pid, which doesn't exist) |
The custom logrotation setup for xapi sometimes conflicted with the normal one. Remove the former. Install the xapi logrotate configuration has been moved to be managed as part of the normal logrotation, with the global settings removed. Duplicate settings in the configuration have been removed. Signed-off-by: Pau Ruiz Safont <[email protected]>
Why is it suspect? Something has to tell rsyslog to reopen its output file otherwise it will continue writing to the rotated log file. |
The custom logrotation sometimes conflicted with the normal one. Remove the former.
Install the xapi logrotate configuration has been moved to be managed as part of the normal logrotation, with the global settings removed.
Drafting as I'm creating the builds