From 130d7b9934792795044edc5d4d39ddae59d46a9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= <edwin.torok@cloud.com>
Date: Thu, 29 Feb 2024 10:36:33 +0000
Subject: [PATCH 1/2] fix(ci): Move differential shellcheck to its own workflow
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It is not supported in scheduled runs, and fails.

Use unique key for shellcheck group

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
---
 .github/workflows/main.yml        | 22 ---------------------
 .github/workflows/shellcheck.yaml | 32 +++++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 22 deletions(-)
 create mode 100644 .github/workflows/shellcheck.yaml

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 7f52439cd69..cadf84c35c4 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -12,28 +12,6 @@ concurrency:  # On new push, cancel old workflows from the same PR, branch or ta
   cancel-in-progress: true
 
 jobs:
-  # https://www.shellcheck.net/wiki/GitHub-Actions
-  # https://github.com/redhat-plumbers-in-action/differential-shellcheck?tab=readme-ov-file#usage
-  shell-test:
-    name: Differential ShellCheck
-    runs-on: ubuntu-latest
-
-    permissions:
-      security-events: write
-    
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-        with:
-            fetch-depth: 0
-
-# If needed severity levels can be controlled here
-#            severity: warning
-      - name: Differential ShellCheck
-        uses: redhat-plumbers-in-action/differential-shellcheck@v5
-        with:
-            token: ${{ secrets.GITHUB_TOKEN }}
-    
   python-test:
     name: Python tests
     runs-on: ubuntu-22.04
diff --git a/.github/workflows/shellcheck.yaml b/.github/workflows/shellcheck.yaml
new file mode 100644
index 00000000000..8725ae60710
--- /dev/null
+++ b/.github/workflows/shellcheck.yaml
@@ -0,0 +1,32 @@
+name: ShellCheck
+
+on:
+  push:
+  pull_request:
+
+concurrency:  # On new push, cancel old workflows from the same PR, branch or tag:
+  group: sc-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  # https://www.shellcheck.net/wiki/GitHub-Actions
+  # https://github.com/redhat-plumbers-in-action/differential-shellcheck?tab=readme-ov-file#usage
+  shell-test:
+    name: Differential ShellCheck
+    runs-on: ubuntu-latest
+
+    permissions:
+      security-events: write
+    
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+            fetch-depth: 0
+
+# If needed severity levels can be controlled here
+#            severity: warning
+      - name: Differential ShellCheck
+        uses: redhat-plumbers-in-action/differential-shellcheck@v5
+        with:
+            token: ${{ secrets.GITHUB_TOKEN }}

From 850183043437b232935cc998ec7601419f6dce7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?T=C3=B6r=C3=B6k=20Edwin?=
 <edwintorok@users.noreply.github.com>
Date: Thu, 29 Feb 2024 13:24:49 +0000
Subject: [PATCH 2/2] Update .github/workflows/shellcheck.yaml
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Pau Ruiz Safont <psafont@users.noreply.github.com>
Signed-off-by: Török Edwin <edwintorok@users.noreply.github.com>
---
 .github/workflows/shellcheck.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/shellcheck.yaml b/.github/workflows/shellcheck.yaml
index 8725ae60710..c17568d821c 100644
--- a/.github/workflows/shellcheck.yaml
+++ b/.github/workflows/shellcheck.yaml
@@ -1,7 +1,6 @@
 name: ShellCheck
 
 on:
-  push:
   pull_request:
 
 concurrency:  # On new push, cancel old workflows from the same PR, branch or tag: