Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epr.py should give visual indication of chapter ending #26

Open
kanliot opened this issue Feb 29, 2020 · 3 comments
Open

epr.py should give visual indication of chapter ending #26

kanliot opened this issue Feb 29, 2020 · 3 comments

Comments

@kanliot
Copy link

kanliot commented Feb 29, 2020

If I go to the second chapter, then use <UP> (up on keyboard) to get to the first chapter, epr.py shows <-- END --> as an indication that I've changed chapters.

  1. when using <DOWN> to reach the last line of the chapter, <-- END --> should display before epr.py switches to next chapter.

It's very surprising to see a new chapter, when I use <DOWN> to read the next line.


  1. when using <PAGEDOWN> to reach the last line of the chapter, I'm often surprised that I have lost my reading position, since an unknown number of lines has scrolled past. I don't know if I've read half the page, or 2/3 of the page, or how many lines of the page.

this should be fixed by prefixing each line from the previous page with a * to indicate that only a partial page has been displayed.

         * lines lines
         * lines lines
         * lines lines
         * lines lines
         * lines lines
         * lines lines
           lines lines
           lines lines
           lines lines
           lines lines
           lines lines
           lines lines
           lines lines
@wustho
Copy link
Owner

wustho commented Feb 29, 2020

Hey there, thanks for feedbacks. Actually the 1st problem you stated above is limitation of this epr, since it process text chapter by chapter allowing epr to run on low memory, at the cost of that 1st problem... To get seamless reading between chapter, it needs to process all text inside epub and process them fast, which is out of my reach since I'm not an actual programmer, just love making script to help my daily life... I tried actually, using multiprocess python packages but, still cannot fully grasp its low level behaviours... Hope somebody will make a pull request regarding this...

2nd problem, I fixed this in https://github.com/wustho/epy but probably forgot to add this patch to epr... So when you hit next page to reach last lines of chapter, you will get a new page containing only that last lines, so we won't lose our reading position, I will add this later to epr, meanwhile you could try https://github.com/wustho/epy

@kanliot
Copy link
Author

kanliot commented Mar 6, 2020 via email

@wustho
Copy link
Owner

wustho commented Oct 29, 2021

@kanliot hey there, been long time. But I added seamless between chapters feature here: https://github.com/wustho/epy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants