Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Connection API #346

Closed
wants to merge 16 commits into from
Closed

Improve Connection API #346

wants to merge 16 commits into from

Conversation

cb0s
Copy link
Member

@cb0s cb0s commented Aug 1, 2021

Clean-up connection API

Should close #267 and #299

CLA

  • I have signed the individual contributor's license agreement and sent it to the board of the WüSpace e. V. organization.

@cb0s cb0s linked an issue Aug 1, 2021 that may be closed by this pull request
Requested Changes Connection API #299
Open
8 tasks
@cb0s cb0s added ▶️ telestion-application Everything related to the telestion-application module 💣 breaking Issue or PR that includes breaking changes 📄 java Pull requests that update Java code 🎩 telestion-services Everything related to the telestion-services module labels Aug 1, 2021
@fussel178 fussel178 changed the title Feat/connection api Improve Connection API Aug 4, 2021
@cb0s cb0s force-pushed the feat/connection-api branch 3 times, most recently from 822aba9 to b0c567d Compare November 14, 2021 12:47
@cb0s cb0s linked an issue Nov 15, 2021 that may be closed by this pull request
Delete de.wuespace.telestion.services.protocol #422
Open
@cb0s
Copy link
Member Author

cb0s commented Nov 15, 2021

Closes parts of #421 and #316

@cb0s cb0s force-pushed the feat/connection-api branch from ad3cad3 to 87fcf04 Compare November 16, 2021 00:19
@fussel178 fussel178 force-pushed the feat/connection-api branch from cf246fd to 3a8f021 Compare December 6, 2021 14:59
@fussel178 fussel178 added this to the v0.9 milestone Jan 31, 2022
fussel178 and others added 7 commits February 25, 2022 15:27
@fussel178
chore: Fix application class in gradle configs
4c7989d
@fussel178 @cb0s
feat(application): Delete deprecated Application class
5fa764a 
Co-authored-by: Cedric Bös <[email protected]>
@fussel178 @cb0s
feat(application): Read JSON configuration from `"de.wuespace.telesti…
bc42393 
…on.configuration"` and refactor

Co-authored-by: Cedric Bös <[email protected]>
@fussel178 @cb0s
refactor(application): Combine duplicated code in Launcher class
ea4fa77 
Co-authored-by: Cedric Bös <[email protected]>
@fussel178 @cb0s
refactor(services): First cleanup of Connection API
3fddff0 
Co-authored-by: Cedric Bös <[email protected]>
@fussel178 @cb0s
feat(services): Both the TCP server and client now wait until every c…
9ed979f 
…onnection is closed.

Co-authored-by: Cedric Bös <[email protected]>
@cb0s @fussel178
feat(connection): Enforce deprecation of old con. api by module design
5665d23 
Move deprecated connection modules to legacy package and remove rework package to allow for one final breaking change once the new connection api is finished.
cb0s added 9 commits February 25, 2022 15:27
@cb0s cb0s modified the milestones: v0.9, v0.10 Mar 4, 2022
@fussel178
Copy link
Member

@cb0s Can I close this PR due to recent inactivity?

@cb0s cb0s closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cb0s cb0s

@fussel178 fussel178

Labels
▶️ telestion-application Everything related to the telestion-application module 💣 breaking Issue or PR that includes breaking changes 📄 java Pull requests that update Java code 🎩 telestion-services Everything related to the telestion-services module
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Delete de.wuespace.telestion.services.protocol Requested Changes Connection API Clean Connection API
2 participants
@cb0s @fussel178