Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatability with typescript-transformer@^2.0 #5

Open
atoff opened this issue May 11, 2023 · 0 comments · May be fixed by #6
Open

Compatability with typescript-transformer@^2.0 #5

atoff opened this issue May 11, 2023 · 0 comments · May be fixed by #6

Comments

@atoff
Copy link

atoff commented May 11, 2023

Hi!

It appears this package doesn't quite work with Version 2 of the typescript-transformer package, as the requirement and interface for the canTransform method in the transformer is no longer used/respected (note it has been removed from the interface https://github.com/spatie/typescript-transformer/blob/2.0.0/src/Transformers/Transformer.php).

New method seems to be to call the canTransform manually in the transform method
@atoff atoff linked a pull request May 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Implement canTransform for typescript-transformer V2 atoff/laravel-enum-transformer
1 participant
@atoff