Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition issues with variant prop in several components like Alert, TextField, etc. #292

Open
3 of 15 tasks
brionmario opened this issue Oct 14, 2024 · 0 comments
Open
3 of 15 tasks

Composition issues with variant prop in several components like Alert, TextField, etc. #292

brionmario opened this issue Oct 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@brionmario
Copy link
Member

Describe the issue:

There are type issues when variant prop is used in certain components.

Ex:

Screenshot 2024-10-14 at 20 35 11

This is reported in MUI as well: mui/material-ui#15697

How to reproduce:

Use the variant prop in Alert

Expected behavior:

TypeScript shouldn't complain.

Additional context :

  • Affected Package:
    • @oxygen-ui/logger
    • @oxygen-ui/primitives
    • @oxygen-ui/react
    • @oxygen-ui/react-icons
  • Library Version: [e.g., 1.10.0, 2.0.0-alpha]
  • OS:
    • Windows
    • Linux
    • Mac
    • Other
  • Browser:
    • Google Chrome
    • Firefox
    • Safari
    • Microsoft Edge
    • Brave
    • Opera
    • Other
@brionmario brionmario added the bug Something isn't working label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brionmario