Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty .scss files to avoid unnecessary style sheet embeds #275

Open
3 of 15 tasks
Tracked by #21415
brionmario opened this issue Oct 8, 2024 · 0 comments
Open
3 of 15 tasks
Tracked by #21415

Remove empty .scss files to avoid unnecessary style sheet embeds #275

brionmario opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working package:react Issues/PRs related to the `@oxygen-ui/react` package.

Comments

@brionmario
Copy link
Member

brionmario commented Oct 8, 2024 •
edited
Loading

Describe the issue:

Currently we have several .scss files without any styles which causes unnecessarily embed stylesheets.

Screenshot 2024-10-08 at 18 25 39

Ref:

oxygen-ui/packages/react/src/components/Typography/typography.scss

Lines 19 to 21 in 2e320ee

.oxygen-typography {
/* Add Styles */
}

How to reproduce:

  • Go to browser developer tools and inspect an element like Typography and observe the empty CSS block.

Expected behavior:

Empty stylesheets should not be included.

Additional context :

  • Affected Package:
    • @oxygen-ui/logger
    • @oxygen-ui/primitives
    • @oxygen-ui/react
    • @oxygen-ui/react-icons
  • Library Version: 1.13.13
  • OS:
    • Windows
    • Linux
    • Mac
    • Other
  • Browser:
    • Google Chrome
    • Firefox
    • Safari
    • Microsoft Edge
    • Brave
    • Opera
    • Other
@brionmario brionmario added bug Something isn't working package:react Issues/PRs related to the `@oxygen-ui/react` package. labels Oct 8, 2024
@brionmario brionmario mentioned this issue Oct 21, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working package:react Issues/PRs related to the `@oxygen-ui/react` package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brionmario