From bdfcbe21dcd8a1af4b55fd84988fb1c7cde5d57d Mon Sep 17 00:00:00 2001 From: akila94 Date: Tue, 17 Dec 2024 13:29:08 +0530 Subject: [PATCH] Resolve PR comments --- .../OBCIBARequestObjectValidationExtension.java | 1 - .../OBCibaGrantHandler.java | 1 - .../ciba/OBCIBASignatureAlgorithmEnforcementValidatorTest.java | 1 - .../extensions/authorize/impl/CIBAConsentPersistStep.java | 1 - .../extensions/authorize/impl/CIBAConsentRetrievalStep.java | 1 - 5 files changed, 5 deletions(-) diff --git a/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCIBARequestObjectValidationExtension.java b/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCIBARequestObjectValidationExtension.java index f354e1b6..c66a2c59 100644 --- a/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCIBARequestObjectValidationExtension.java +++ b/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCIBARequestObjectValidationExtension.java @@ -38,7 +38,6 @@ * The extension of RequestObjectValidatorImpl to enforce Open Banking specific validations of the * request object. */ -@Deprecated public class OBCIBARequestObjectValidationExtension extends CIBARequestObjectValidatorImpl { private static final Log log = LogFactory.getLog(OBCIBARequestObjectValidationExtension.class); diff --git a/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCibaGrantHandler.java b/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCibaGrantHandler.java index abd6804f..f656bc7c 100644 --- a/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCibaGrantHandler.java +++ b/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/main/java/com.wso2.openbanking.accelerator.ciba/OBCibaGrantHandler.java @@ -31,7 +31,6 @@ /** * OB specific CIBA grant handler. */ -@Deprecated public class OBCibaGrantHandler extends CibaGrantHandler { private static final ConsentCoreServiceImpl consentCoreService = new ConsentCoreServiceImpl(); diff --git a/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/test/java/com/wso2/openbanking/accelerator/ciba/OBCIBASignatureAlgorithmEnforcementValidatorTest.java b/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/test/java/com/wso2/openbanking/accelerator/ciba/OBCIBASignatureAlgorithmEnforcementValidatorTest.java index 03335e31..8de0c7ce 100644 --- a/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/test/java/com/wso2/openbanking/accelerator/ciba/OBCIBASignatureAlgorithmEnforcementValidatorTest.java +++ b/open-banking-accelerator/components/com.wso2.openbanking.accelerator.ciba/src/test/java/com/wso2/openbanking/accelerator/ciba/OBCIBASignatureAlgorithmEnforcementValidatorTest.java @@ -49,7 +49,6 @@ @PowerMockIgnore("jdk.internal.reflect.*") @PrepareForTest({IdentityCommonUtil.class, OAuthServerConfiguration.class}) -@Deprecated public class OBCIBASignatureAlgorithmEnforcementValidatorTest extends PowerMockTestCase { diff --git a/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentPersistStep.java b/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentPersistStep.java index 285cad37..b59136d7 100644 --- a/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentPersistStep.java +++ b/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentPersistStep.java @@ -43,7 +43,6 @@ /** * Consent persistence step for CIBA flow. */ -@Deprecated public class CIBAConsentPersistStep implements ConsentPersistStep { private static final Log log = LogFactory.getLog(CIBAConsentPersistStep.class); diff --git a/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentRetrievalStep.java b/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentRetrievalStep.java index c2e8eca6..b5fe62c8 100644 --- a/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentRetrievalStep.java +++ b/open-banking-accelerator/components/consent-management/com.wso2.openbanking.accelerator.consent.extensions/src/main/java/com/wso2/openbanking/accelerator/consent/extensions/authorize/impl/CIBAConsentRetrievalStep.java @@ -30,7 +30,6 @@ /** * Consent retrieval step for CIBA flow. */ -@Deprecated public class CIBAConsentRetrievalStep implements ConsentRetrievalStep { private static final Log log = LogFactory.getLog(CIBAConsentRetrievalStep.class);