Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 compatibility #2

Open
josemi-ca opened this issue Nov 7, 2016 · 13 comments
Open

PHP7 compatibility #2

josemi-ca opened this issue Nov 7, 2016 · 13 comments

Comments

@josemi-ca
Copy link

The plugin doesn't work under PHP 7:

Read here: https://wordpress.org/support/topic/php-7-support-3/

@danieldunderfelt
Copy link

This would be quite important to get working. Everyone on PHP7 basically SOL because there's no other plugin like P3.

@frankiejarrett
Copy link

Long story short is this is going to require a complete rewrite of P3.

PHP 7 is pretty amazing, but unfortunately it broke backwards compatibility with the way debug_backtrace() has fundamentally worked in the past, which P3 and other profilers rely on to profile the call stack.

As you can imagine, this is going to take a considerable amount of planning, time and help because we'd essentially be throwing away what we have and starting from scratch. Additionally, whatever approach is decided for the profiler engine to work on PHP 7 would still need to be PHP 5.4 compatible as well, at minimum.

@JavierSegoviaCordoba
Copy link

Any update about this?

@xtechgamer735
Copy link

Its a bit out of order that GoDaddy, one of the biggest hosting companies in the business cant spare a few developers for a few days. Or just delete the plugin.

@nemeth-it
Copy link

Sad, at the current point I could need this plugin a lot.

I'm surprised that there is no warning on the Wordpress Plugin Page (installed and Repository). With such a big incompatibility issue it could become weeks or month until a wordpress-admin would recognizes deprecated or not longer maintained plugins.

So not everything is GoDaddys or the plugin-developers fault. But I would suggest, that they add more hints about this issue on the about-page until it got fixed.

@MACscr
Copy link

MACscr commented Mar 10, 2018

yep. pretty disappointed myself. No other plugin exists that i know of that works like this one too.

@nemeth-it
Copy link

Working like this one, is true. P3-Profiler was really helpful zu visualize slow plugins really well. But there are still plugins who do also a good job to find the reason why a WP-Installation runs suddenly so slowly.

I use Query Monitor now, as long it is activated, it shows in the too-bar on each page-load what and how many stuff got loaded and slowed down your page. (Querys from Themes, Plugins, Hooks and so on.)

@webdados
Copy link

RIP P3 :-(

@mkormendy
Copy link

Long story short is this is going to require a complete rewrite of P3.

PHP 7 is pretty amazing, but unfortunately it broke backwards compatibility with the way debug_backtrace() has fundamentally worked in the past, which P3 and other profilers rely on to profile the call stack.

As you can imagine, this is going to take a considerable amount of planning, time and help because we'd essentially be throwing away what we have and starting from scratch. Additionally, whatever approach is decided for the profiler engine to work on PHP 7 would still need to be PHP 5.4 compatible as well, at minimum.

So stop wasting time and start rewriting. 😀

@davidfavor
Copy link

https://wordpress.org/about/requirements - state minimum PHP version is now 7.3 so seems like targeting support for 5.4 - 5.6 might require a huge effort, for very little gain.

Just a thought.

@r44cx
Copy link

r44cx commented Sep 11, 2020

@NoZIMM Not related to this issue, at all.

woops, wrong tab

@MACscr
Copy link

MACscr commented Sep 11, 2020

Long story short is this is going to require a complete rewrite of P3.

PHP 7 is pretty amazing, but unfortunately it broke backwards compatibility with the way debug_backtrace() has fundamentally worked in the past, which P3 and other profilers rely on to profile the call stack.

As you can imagine, this is going to take a considerable amount of planning, time and help because we'd essentially be throwing away what we have and starting from scratch. Additionally, whatever approach is decided for the profiler engine to work on PHP 7 would still need to be PHP 5.4 compatible as well, at minimum.

like anyone that cares about performance is running anything less than php 7

@gabriel-munteanu
Copy link
Contributor

I did a fix for this issue. There is a pull request for this: #8. Meanwhile you can download the plugin with the fix included from here: https://github.com/gabriel-munteanu/wp-p3-profiler/blob/master/p3-profiler.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests