-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merl 1147 faustwp block editor block controls implement color control #1566
Merl 1147 faustwp block editor block controls implement color control #1566
Conversation
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Changeset exist on a different branch.
…-color-control' of https://github.com/wpengine/faustjs into MERL-1147-faustwp-block-editor-block-controls-implement-color-control
Hi @theodesp ! I wanted to ask two clarifying questions on the ticket associated with this PR:
|
Hey @TeresaGobble.
you can use this guide here: |
…ols-implement-color-control
🦋 Changeset detectedLatest commit: f6cbf2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the test you may add this looks great. Awesome job!
Tasks
Description
This PR meets the needs outlined in MERL-1147 , adding the Color control utility outlined in the RFC for React Components to Gutenberg blocks, here.
Related Issue(s):
This PR merged in changes from MERL-1149.
Testing
After pulling this branch down, run the following commands in the faustjs monorepo:
npm install
npm run build
npm run build -w packages/block-editor-utils
cd packages/block-editor-utils
npm link
Switch to your testing site's repo.
6. On your WordPress instance create a new block plugin using @wordpress/create-block
npx @wordpress/create-block hello-world-block
7. cd to your new block plugin's folder
8. Inside the
hello-world-block
plugin folder, runnpm link @faustwp/block-editor-utils
to add a reference to the package.9. Replace
hello-world-block
's generated index.js file with the below code block:hello-world-block
's generated `block.json file with the below code block.In
app/public/wp-content/plugins/hello-world-block/src/block.json
:HelloWorld.js
and add the below code block.Run
npm start
from your plugin's file,hello-world-block
.After ensuring your block plugin,
Hello World Block
is active.Go into the editor and try to create a new
Hello World Block
block. You should look to the sidebar and see the colorPicker panel visible. Ensure that upon selecting a color and navigating away and back to the block, that the color has been saved. See the below video for expected behavior:Screen.Recording.2023-09-06.at.2.26.04.PM.mov
Documentation Changes