-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MERL-1136: Deploy WP Plugin - Github Actions #1549
Conversation
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see from the output in the test action, that the proper version 0.8.9
was saved to the env var:
https://github.com/wpengine/faustjs/actions/runs/5968538931/job/16192566006?pr=1549
This looks good! There is no real way to test this unless we do a real release, so we'll want to double check it was effective once we do a plugin release.
Before we merge, Let's remove the .github/workflows/test.yml
file as well just for tidying up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just formalizing Blake's suggestion:
Before we merge, Let's remove the .github/workflows/test.yml file as well just for tidying up.
Description
Updated release-packages workflow in Github to deploy the wordpress plugin.
Testing
Ensure the plugin is deployed during the pipeline running for release. As this only happens during release, we can't test it except locally for the version in the script.
LOCAL:
We had to get the version for the plugin to be deployed. To get the version locally: