Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERL-1136: Deploy WP Plugin - Github Actions #1549

Merged
merged 20 commits into from
Aug 29, 2023
Merged

Conversation

matthewguywright
Copy link
Contributor

@matthewguywright matthewguywright commented Aug 24, 2023

Description

Updated release-packages workflow in Github to deploy the wordpress plugin.

Testing

Ensure the plugin is deployed during the pipeline running for release. As this only happens during release, we can't test it except locally for the version in the script.

LOCAL:
We had to get the version for the plugin to be deployed. To get the version locally:

  1. Pull branch
  2. Create a feature branch
  3. Create a PR for the branch
  4. Watch the version be output by the Test Plugin Version build step
  5. There should be a version equal to xx.xx.xx or .x.x.x, ex. "0.8.9"

@matthewguywright matthewguywright requested a review from a team as a code owner August 24, 2023 17:47
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

⚠️ No Changeset found

Latest commit: 45ac68d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@blakewilson blakewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see from the output in the test action, that the proper version 0.8.9 was saved to the env var:

https://github.com/wpengine/faustjs/actions/runs/5968538931/job/16192566006?pr=1549

This looks good! There is no real way to test this unless we do a real release, so we'll want to double check it was effective once we do a plugin release.

Before we merge, Let's remove the .github/workflows/test.yml file as well just for tidying up.

Copy link
Contributor

@mindctrl mindctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just formalizing Blake's suggestion:

Before we merge, Let's remove the .github/workflows/test.yml file as well just for tidying up.

@mindctrl mindctrl merged commit bfdf19b into canary Aug 29, 2023
13 checks passed
@mindctrl mindctrl deleted the feature/mw-merl-1136 branch August 29, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants