-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: InspectorFields component #1547
Conversation
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Hey @theodesp, I followed your testing instructions, but I'm not seeing the same thing. It looks like there are no new editor fields when I try and edit the block: |
Are there any console errors you can share? I tried the steps on a new plugin without issues. |
@theodesp Nope, no console errors that stand out 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ran through the testing steps with Theo during a meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tasks
Description
Related Issue(s):
#1522
Testing
npm install
npm run build -w packages/block-editor-utils
cd packages/block-editor-utils
npm link
npx @wordpress/create-block hello-world-block
npm link @faustwp/block-editor-utils
to add a reference to the package.index.js
editor script to use theregisterFaustBlock
helper function instead adding the hook for testing the controlsHere
HelloWorld
is a simple Div Component with theeditorFields
config that contains a color fieldRun
npm start
to build the compiled jsNow go into the editor and try to create a new block. You should be able to see the Edit mode component. On the sidebar you can see the example color control component that we defined for testing purposes.
Screenshots
Documentation Changes
Dependant PRs