Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Audit: False positive when URL is duplicated in plugin header #122

Closed
danielbachhuber opened this issue Dec 17, 2018 · 1 comment
Closed

Comments

@danielbachhuber
Copy link
Member

Similar to #96, I'm seeing an unexpected error when the same URL is listed twice in my plugin header:

$ wp i18n make-pot . languages/tasty-pins.pot
Plugin file detected.
Warning: The string "https://www.wptasty.com" has 2 different translator comments.
Success: POT file successfully generated!
<?php
/**
 * Plugin Name:     Tasty Pins
 * Plugin URI:      https://www.wptasty.com
 * Description:     Optimize your blog’s images for Pinterest, SEO, and screenreaders.
 * Author:          WP Tasty
 * Author URI:      https://www.wptasty.com
 * Text Domain:     tasty-pins
 * Domain Path:     /languages
 * Version:         0.8.0-alpha
 *
 * @package         Tasty_Pins
 */
@swissspidy
Copy link
Member

Looking at fixing this now.

FWIW I think the WordPress.org Plugin Directory requires Author URI and Plugin URI to be separate.

But I guess the same issue also appears when using __( 'https://www.wptasty.com', 'tasty-pins' ); somewhere further down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants