Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If we are inside a transaction, our subcollections should also be TransactionRepositories #305

Open
tomorroN opened this issue Jun 10, 2022 · 1 comment
Open

If we are inside a transaction, our subcollections should also be TransactionRepositories #305

tomorroN opened this issue Jun 10, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tomorroN
Copy link

tomorroN commented Jun 10, 2022 •
edited
Loading

Change ISubCollection<Entity> type into ITransactionRepository<Entity> if interacting with subcollection inside transaction
@wovalle
Copy link
Owner

wovalle commented Jun 17, 2022

Hi @tomorroN, great observation!

Can you open a PR fixing this type?

@wovalle wovalle added enhancement New feature or request help wanted Extra attention is needed labels Jun 17, 2022
@elersong elersong mentioned this issue Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wovalle @tomorroN