Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2: Some posts cannot be followed from Reader #22617

Open
twstokes opened this issue Feb 15, 2024 · 2 comments
Open

P2: Some posts cannot be followed from Reader #22617

twstokes opened this issue Feb 15, 2024 · 2 comments

Comments

@twstokes
Copy link
Contributor

twstokes commented Feb 15, 2024

Expected behavior

The "Follow Conversation" option to be present.

Actual behavior

The "Follow Conversation" option is not present on some P2s.

Steps to reproduce the behavior

  1. Load a P2 post using the Notifications tab
  2. Observe the "Follow Conversation" option at the bottom (see screenshot above)
  3. Load a P2 post using the Reader tab
  4. Observe there is no "Follow Conversation" option at the bottom for some P2s
Tested on iPhone 15 Pro, iOS 17, Jetpack iOS 24.2
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@twstokes
Copy link
Contributor Author

Research from @wargcm 🙇:

It looks like it's due to the canSubscribeComments property on the posts, which we get from the backend. For whatever reason, on the Automattic feed, it returns false and from the notifications screen has it as true

It returns false for web too, but I guess they don't hide the Follow Conversation if it's false

It looks like Android may not be checking that property, so it might appear correctly on Android. Maybe we could update iOS' logic to match Android's. I'm also wondering if the backend has changed recently or if it just always returned false for the Automattic feed

@jkmassel jkmassel removed the P2 label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants