Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontForTextStyle(_ style: maximumPointSize:) doesn't use maximumPointSize parameter in the implementation #315

Open
staskus opened this issue Sep 29, 2022 · 0 comments
Labels

Comments

@staskus
Copy link
Contributor

staskus commented Sep 29, 2022

fontForTextStyle(_ style: maximumPointSize:) doesn't use maximumPointSize parameter in the implementation. This method is used in some parts of the WordPress-iOS application and is features in the accessibility guide.

It was removed in the #294 PR.

    @objc public class func fontForTextStyle(_ style: UIFont.TextStyle, maximumPointSize: CGFloat = maxFontSize) -> UIFont {
        let fontDescriptor = UIFontDescriptor.preferredFontDescriptor(withTextStyle: style)
        return UIFont(descriptor: fontDescriptor, size: fontDescriptor.pointSize)
    }

a) If we don't want to support maximumPointSize anymore, remove it from method signature.
b) If we want to support maximumPointSize change implementation to use fontDescriptor method that uses maximumPointSize.

@staskus staskus added the bug label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant