[BE] refactor: 알림 서비스 다른 도메인 의존성 제거 #740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehtjsv2
requested review from
jimi567,
J-I-H-O and
takoyakimchi
as code owners
Test Results226 tests +149 226 ✅ +149 19s ⏱️ +18s Results for commit 2e452d7. ± Comparison against base commit 6bc242f. This pull request removes 77 and adds 226 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
takoyakimchi
previously approved these changes
Nov 20, 2024
Comment on lines
+35
to
+36
| notificationService.sendNotification( | ||
| DEFAULT_TITLE, |
There was a problem hiding this comment.
예전에 작성된 코드같긴 한데
하는 김에 DEFAULT_TITLE을 static으로 두면 어떨까요?
|
|
||
| void sendFootprintNotification(String title, String content, List<String> receiverTokens); | ||
|
|
||
| void sendChatNotification(Long chatRoomId, ChatMessageSocketResponse response, Club club); | ||
|
|
||
| void sendPlaygroundJoinNotification(String title, String content, List<String> receiverTokens); |
Comment on lines
+37
to
+38
| "profilePictureUrl", response.profilePictureUrl() == null ? "" : response.profilePictureUrl(), | ||
| "clubPictureUrl", club.getImageUrl() == null ? "" : club.getImageUrl(), |
There was a problem hiding this comment.
테스트가 터져서 확인해보니 해당부분 문제가 보이더라구요~!
J-I-H-O
previously approved these changes
Nov 22, 2024
Comment on lines
3
to
4
| import static com.happy.friendogly.notification.domain.NotificationType.FOOTPRINT; | ||
|
|
There was a problem hiding this comment.
static import는 제거하는게 어떨까요?
클래스 내부에 선언된 private 상수인지, 공통적으로 사용하는 enum인지 알아보기 어려워지는 것 같습니다.
ehtjsv2
dismissed stale reviews from jimi567, J-I-H-O, and takoyakimchi
via
2e452d7
takoyakimchi
approved these changes
Nov 25, 2024
J-I-H-O
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항