Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 투표 도메인 리팩터링 #514

Open
3 tasks done
woo-chang opened this issue Sep 4, 2023 · 0 comments · May be fixed by #727
Open
3 tasks done

[REFACTOR] 투표 도메인 리팩터링 #514

woo-chang opened this issue Sep 4, 2023 · 0 comments · May be fixed by #727
Assignees
@aiaiaiai1
Labels
BE 🌀 우선 순위 낮음 🛠 리팩터링
Milestone
최종 데모데이

Comments

@woo-chang
Copy link
Collaborator

woo-chang commented Sep 4, 2023 •
edited
Loading

✨ 추가 기능

투표 도메인을 리팩터링합니다.

📆 일정 추정

6시간

📃 세부 사항

  • 투표 로직을 리팩터링합니다.
  • 투표 코드 가독성을 개선합니다.
  • 투표 로직 테스트 코드를 작성합니다.

✅ 투두리스트

  • 투표 로직 리팩터링
  • 투표 코드 가독성 개선
  • 투표 로직 테스트

🔗 참고 자료
@woo-chang woo-chang added this to the 5차 데모데이 milestone Sep 4, 2023
aiaiaiai1 added a commit that referenced this issue Oct 9, 2023
@aiaiaiai1
refactor: (#514) Post 객체에서 vote 의존성 제거
91bb5aa 
- 투표시 마감기간, 선택지 옵션 검증로직 serivce계층에 위임
- 투표시 작성자 검증 로직 Vote 도메인에 위임
aiaiaiai1 added a commit that referenced this issue Oct 9, 2023
@aiaiaiai1
test: (#514) VoteService, Vote 테스트 코드 추가
def5a4f
aiaiaiai1 added a commit that referenced this issue Oct 9, 2023
@aiaiaiai1
refactor: (#514) docs 개행 수정
1f91424
aiaiaiai1 added a commit that referenced this issue Oct 9, 2023
@aiaiaiai1
Merge branch 'dev' into refactor/#514
7735524
@aiaiaiai1 aiaiaiai1 self-assigned this Oct 9, 2023
@aiaiaiai1 aiaiaiai1 linked a pull request Oct 9, 2023 that will close this issue
Open
aiaiaiai1 added a commit that referenced this issue Oct 9, 2023
@aiaiaiai1
test: (#514) 테스트 실패 코드 수정
0f56c56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiaiaiai1 aiaiaiai1

Labels
BE 🌀 우선 순위 낮음 🛠 리팩터링
Projects
2023-votogether
Status: Todo
Milestone
최종 데모데이
Development

Successfully merging a pull request may close this issue.

[REFACTOR] 투표 도메인 리팩터링 woowacourse-teams/2023-votogether
4 participants
@woo-chang @Gilpop8663 @tjdtls690 @aiaiaiai1