From c64fdb9a0e107eb13cf892b2bf52101990b53e29 Mon Sep 17 00:00:00 2001 From: chaewon121 Date: Tue, 7 Nov 2023 00:25:02 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20=ED=85=8C=EC=8A=A4=ED=8A=B8=20?= =?UTF-8?q?=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../letter/application/LetterServiceTest.java | 74 ++----------------- 1 file changed, 7 insertions(+), 67 deletions(-) diff --git a/backend/src/test/java/com/now/naaga/letter/application/LetterServiceTest.java b/backend/src/test/java/com/now/naaga/letter/application/LetterServiceTest.java index 62313b6d6..466162867 100644 --- a/backend/src/test/java/com/now/naaga/letter/application/LetterServiceTest.java +++ b/backend/src/test/java/com/now/naaga/letter/application/LetterServiceTest.java @@ -11,6 +11,7 @@ import com.now.naaga.game.exception.GameExceptionType; import com.now.naaga.letter.application.dto.CreateLetterCommand; import com.now.naaga.letter.domain.Letter; +import com.now.naaga.letter.domain.letterlog.LetterLogType; import com.now.naaga.letter.domain.letterlog.ReadLetterLog; import com.now.naaga.letter.exception.LetterException; import com.now.naaga.letter.presentation.dto.FindNearByLetterCommand; @@ -182,9 +183,14 @@ class LetterServiceTest { // when final Letter actual = letterService.findLetter(new LetterReadCommand(player.getId(), letter.getId())); + final List actualLog = readLetterLogRepository.findAll(); + // then - assertThat(actual.getId()).isEqualTo(letter.getId()); + assertSoftly(softAssertions -> { + softAssertions.assertThat(actual.getId()).isEqualTo(letter.getId()); + softAssertions.assertThat(actualLog).hasSize(1); + }); } @Test @@ -215,70 +221,4 @@ class LetterServiceTest { LetterException.class, () -> letterService.findLetter(new LetterReadCommand(player.getId(), letter.getId() + 1))); assertThat(letterException.exceptionType()).isEqualTo(NO_EXIST); } - - @Test - void 읽은쪽지로그에_데이터를_저장한다() { - // given - final Player player = playerBuilder.init() - .build(); - - final Place destination = placeBuilder.init() - .position(잠실_루터회관_정문_좌표) - .build(); - - final Game game = gameBuilder.init() - .place(destination) - .player(player) - .startPosition(잠실역_교보문고_좌표) - .build(); - - final Player letterRegister = playerBuilder.init() - .build(); - - final Letter letter = letterBuilder.init() - .registeredPlayer(letterRegister) - .build(); - - // when - letterService.logReadLetter(player, letter); - - // then - final List actual = readLetterLogRepository.findAll(); - final long expected = actual.get(0).getLetter().getId(); - - assertSoftly(softAssertions -> { - softAssertions.assertThat(actual).hasSize(1); - softAssertions.assertThat(expected).isEqualTo(letter.getId()); - }); - } - - @Test - void 읽은쪽지로그에_데이터저장시_진행중인_게임이없으면_예외가_발생한다() { - // given && when - final Player player = playerBuilder.init() - .build(); - - final Place destination = placeBuilder.init() - .position(잠실_루터회관_정문_좌표) - .build(); - - final Game game = gameBuilder.init() - .place(destination) - .player(player) - .startPosition(잠실역_교보문고_좌표) - .gameStatus(GameStatus.DONE) - .build(); - - final Player letterRegister = playerBuilder.init() - .build(); - - final Letter letter = letterBuilder.init() - .registeredPlayer(letterRegister) - .build(); - - //then - final GameException gameException = assertThrows( - GameException.class, () -> letterService.logReadLetter(player, letter)); - assertThat(gameException.exceptionType()).isEqualTo(NOT_EXIST_IN_PROGRESS); - } }