Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if the workflow itself is invalid #53

Open
woodruffw opened this issue Oct 27, 2024 · 1 comment
Open

Warn if the workflow itself is invalid #53

woodruffw opened this issue Oct 27, 2024 · 1 comment
Assignees

Comments

@woodruffw
Copy link
Owner

Per #51 -- sometimes people put settings directly on the step: body without a with: clause, which both doesn't affect GHA and also causes a confusing message from zizmor (since it complains about the same audit finding, but the "fix" is also visible in the render).

To improve this, we could warn if a Step body has keys other than the ones we expect. This probably needs to be done in github-actions-models and then propagated as an error here.

@woodruffw woodruffw self-assigned this Oct 27, 2024
@woodruffw
Copy link
Owner Author

Nothing for myself: we could achieve this by adding #[serde(deny_unknown_fields)] to most of the github-actions-models models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant