-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ECE for payment processing on block checkout page #3439
Conversation
@wjrosa I have requested your review as you are also working on ECE issues. Feel free to unassign yourself if you are too occupied 🍫 |
@wjrosa @annemirasol this PR is ready for review again. The changes seems to work for block cart page as well. So please test this on both the block cart and block checkout pages. There are 2 issues I am going to fix separately.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Mayisha! Code is good and it works as expected:
Confirm that the Google Pay and Apple Pay buttons are loaded.
Confirm that you can successfully place an order with Google Pay and Apple Pay.
Confirm that the Google Pay and Apple Pay buttons are loaded.
Confirm that you can successfully place an order with Google Pay and Apple Pay.
Disable the feature flag and confirm that PRBs are still working without any regression.
This could be a me thing, but I can't get Apple Pay to show up on this branch, when ECE is enabled. How it looks on How it looks for this branch, with I was able to test Google Pay, and these scenarios worked as expected ✨
Some other things I observed, which I think are out-of-scope for this PR, but noting here to document. LMK if you want me to file issues for these.
Cart: Apple Pay/Google Pay are not enabled as payment methods, Checkout: Apple Pay/Google Pay are not enabled as payment methods, UAE addresses aren't being mapped correctly. This was recently fixed for PRBs: |
Not just a you thing I thing. I'm seeing the same thing. I noticed the following error in my console log: Fixing that (see this comment) will fix it for me. :) |
Thanks everyone for the review. @annemirasol these are good findings.
I will fix it under #3470
|
Fixes #3403 #3408
Changes proposed in this Pull Request:
Testing instructions
is_stripe_ece_enabled
function or in your database add an option_wcstripe_feature_ece
and set yes as the value).