Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing the Checkout Block displays express payment method buttons even when they are disabled #3437

Open
alexflorisca opened this issue Sep 16, 2024 · 1 comment · May be fixed by #3523
Open

Editing the Checkout Block displays express payment method buttons even when they are disabled #3437

alexflorisca opened this issue Sep 16, 2024 · 1 comment · May be fixed by #3523
Assignees
@annemirasol
Labels
type: bug The issue is a confirmed bug.

Comments

@alexflorisca
Copy link
Member

alexflorisca commented Sep 16, 2024 •
edited by csmcneill
Loading

Describe the bug

Express payment method buttons are displayed when editing the Checkout Block even all express payment methods are is disabled in the Stripe for WooCommerce settings.

Note

This only seems to affect Apple Pay and Google Pay.

To Reproduce

  1. Go to Stripe settings page
  2. Disable all express payment methods.
  3. Open the Checkout Block page in the editor
  4. See that the express payment method buttons are still rendered in the editor

Actual behavior

Express payment method buttons are visible in the editor when they are disabled in settings.

Screenshots

CleanShot 2024-09-18 at 21 07 28

Expected behavior

Express payment method buttons should not be visible in the editor when they are disabled in settings.

Potential solution

We should only call registerExpressPaymentMethod if it is enabled from the Stripe settings page.
@csmcneill csmcneill mentioned this issue Sep 19, 2024
Closed
@csmcneill
Copy link

Hey @alexflorisca! Thanks for reporting!

I can reproduce this issue with Stripe for WooCommerce and WooPayments.

I did a couple of things as a result:

  1. I edited your report for some additional clarity.
  2. I provided a screenshot of my test site.
  3. I reported this issue in the WooPayments repo as well: Editing the Checkout Block displays express payment method buttons even when they are disabled Automattic/woocommerce-payments#9465

@csmcneill csmcneill changed the title Google & Apple Pay buttons are displayed in editor even when the payment method is disabled Editing the Checkout Block displays express payment method buttons even when they are disabled Sep 19, 2024
@csmcneill csmcneill added the type: bug The issue is a confirmed bug. label Sep 19, 2024
@annemirasol annemirasol self-assigned this Oct 17, 2024
@annemirasol annemirasol linked a pull request Oct 17, 2024 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annemirasol annemirasol

Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide Express Checkout in block editor if disabled woocommerce/woocommerce-gateway-stripe
3 participants
@annemirasol @alexflorisca @csmcneill