Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deferred intent] Prevent duplicated / mistaken payment processing of orders #2785

Open
a-danae opened this issue Nov 23, 2023 · 2 comments
Open

Comments

@a-danae
Copy link
Contributor

a-danae commented Nov 23, 2023

Problem

We must only attempt to create and confirm an intent for orders with a pending/failed status.

We could check that $order->needs_payment() before processing a payment for this.

There could also be other variables to consider for preventing this behavior, like webhooks processing a payment or changing the order status, or caching that doesn't reflect the actual status of the order.

Acceptance criteria

  • Spike: Identify the scenarios where we may mistakenly process a payment.
  • Provide fixes for them, or create separate issues if it's more convenient for handling each scenario.

Context

Copy link

Hi,
This issue has gone 150 days (5 months) without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest version, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

Copy link

This issue has gone 180 days (6 months) without any activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant