Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If possible I would suggest adding VaadinCKEditorElement so that the component can be used with TestBench? #50

Open
FollowSteph opened this issue Jul 6, 2023 · 2 comments

Comments

@FollowSteph
Copy link

It could just be that I'm not seeing it but if not it would be a great addition to be able to run TestBench with VaadinCKEditor. My understanding is that it needs a VaadinCKEditorElement class to be able to test (at least easily) but I could be wrong. If I'm not wrong then I would suggest adding this as it would be very helpful.

@eroself
Copy link
Collaborator

eroself commented Jul 8, 2023

No sure what to be achieved for running TestBench. If you want to test in Element level, you could VaadinCKEditor.getElement(). Cheers

@FollowSteph
Copy link
Author

FollowSteph commented Jul 9, 2023

For example when I use testbench my code is:

$(ComboBoxElement.class).id(id).selectByText(value);
// or $(ComboBoxElement.class).first() if there's only one which is almost always the case.

In other words I don't necessarily have an instance of CKEditor. I have been using something like:

ExpectedConditions.presenceOfElementLocated(By.id("ckeditor-wrapper"));

which I assume I could also use to grab the CKEditor (By.id("ckeditor-wrapper")) and go from there but it would be a lot cleaner and more standard to be able to just do $(VaadinCKEditorElement.class). It's definitely more of a suggested nicety to keep things standard since there are other ways to get the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants