Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheels with 5 dashes not split correctly in file_to_package #88

Open
callumnoble opened this issue May 13, 2019 · 4 comments
Open

Wheels with 5 dashes not split correctly in file_to_package #88

callumnoble opened this issue May 13, 2019 · 4 comments

Comments

@callumnoble
Copy link

callumnoble commented May 13, 2019 •
edited
Loading

pep-0427 allows for an optional build tag introducing a fifth dash:
https://www.python.org/dev/peps/pep-0427/#file-name-convention

>>> file_to_package("PySide2-5.12.3-5.12.3-cp35.cp36.cp37-abi3-manylinux1_x86_64.whl")
('PySide2-5.12.3', '5.12.3-cp35.cp36.cp37-abi3-manylinux1_x86_64.whl')

should be

>>> file_to_package("PySide2-5.12.3-5.12.3-cp35.cp36.cp37-abi3-manylinux1_x86_64.whl")
('PySide2', '5.12.3-5.12.3-cp35.cp36.cp37-abi3-manylinux1_x86_64.whl')
callumnoble pushed a commit to callumnoble/pip2pi that referenced this issue May 13, 2019
Allow 5 dash in whl filename (wolever#88)
efe6dac
callumnoble added a commit to callumnoble/pip2pi that referenced this issue May 13, 2019
@callumnoble
Allow 5 dash in whl filename (wolever#88)
5bd8be6
@ttf-brians
Copy link

ttf-brians commented Apr 13, 2023 •
edited
Loading

Also affected by this, with this exact package as well as with the shiboken2 package.

Finding your fork got me a working fix. Thank you!

@mattmalcher mattmalcher mentioned this issue May 25, 2023
Open
@georgevreilly
Copy link
Contributor

Similarly, triton-2.1.0-0-cp38-cp38-manylinux2014_x86_64.manylinux_2_17_x86_64.whl created a directory named simple/triton-2-1-0

@georgevreilly
Copy link
Contributor

You should probably be using a regex like https://github.com/pypa/wheel/blob/main/src/wheel/wheelfile.py#L15-L21 to extract information from the wheel filename.

georgevreilly pushed a commit to georgevreilly/torch21 that referenced this issue Apr 12, 2024
@georgevreilly-stripe
Patch for pip2pi==0.8.2
b5d0861 
Fixes wolever/pip2pi#88
@georgevreilly
Copy link
Contributor

You can also use my patcher tool to create a patched pip2pi wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgevreilly @callumnoble @ttf-brians