Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add daycli test #803

Merged
merged 10 commits into from
Nov 19, 2024
Merged

add daycli test #803

merged 10 commits into from
Nov 19, 2024

Conversation

maaikelimper
Copy link
Collaborator

@maaikelimper maaikelimper marked this pull request as ready for review November 19, 2024 10:00
david-i-berry
david-i-berry requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@david-i-berry david-i-berry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm whether 30 or 31 messages are expected for DAYCLI test. There are only 30 records in the sample file so it's unclear where the 31st is coming from.

tests/integration/test_workflow.py Show resolved Hide resolved
@maaikelimper maaikelimper merged commit 1bfc623 into main Nov 19, 2024
6 checks passed
@maaikelimper maaikelimper deleted the issue-779-daycli branch November 19, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-i-berry david-i-berry david-i-berry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maaikelimper @david-i-berry