Skip to content

Latest commit

 

History

History
107 lines (75 loc) · 5.34 KB

CONTRIBUTING.md

File metadata and controls

107 lines (75 loc) · 5.34 KB
Raw

Contributing to pDSL

First of all, thank you for taking your time to contribute to pDSL!

I don't want to contribute, I just have some questions! :S

Code of Conduct

We are a friendly and welcoming open source community. You can find our code of conduct here.

During Development

Commits

Please follow our simple commit style guidelines.

  1. Prepend all commits with a topic. Available topics are:
    • [core] For changes to ink_core
    • [model] For changes to ink_model
    • [lang] For changes to ink_lang
    • [cli] For changes to cargo-pdsl also known as pdsl_cli
    • [ci] For changes to the continuous integration.
    • [chores] For general non-technical changes.
    • [examples/{core,model,lang}] For changes to the examples in either core, model or lang.

For other purposes and sections please try to find a good fit for the topic.

Checklist

Below is a checklist for you before doing a pull request. Following these will ensure that your pull request is going to be accepted.

  1. Run rustfmt automatically.
  2. Run clippy on your changes.
  3. Run tests in debug and release mode using --features test-env for off-chain testing.
  4. For critical parts perform some manual on-chain tests.
  5. Build the code and run tests also for the wasm32 target.
  6. Try to run some examples and see if they are still working correctly.
  7. Sometimes clippy lints can be unfortunate or even buggy and it can be very hard to fix those. In these situations you may skip the clippy lint with #[clippy::skip], however, note that this always requires a good rational as a side-comment and probably link to the eventual clippy bug.
  8. Important Strive for simple, clean and concise code. If your code is very complex - because it is trying to accomplish complex things - try to think about how another aproach or design could simplify it.
  9. We won't accept a pull request with FIXME or TODO comments in it. Please try to fix them by yourself and resolve all remaining to-do items. If that is not possible then write an issue for each of them and link to the source line and commit with a proper description. For more information go here.
  10. Document everything properly that you have written, refactored or touched. Especially keeping documentation up-to-date is very important. For larger portions please try to also update the pDSL wiki or write a new entry there.
  11. Write tests for your code. If your code is hard to test, try to find a design that allows for testability.
  12. If needed also update the README.
  13. For performance critical parts we also want additional performance tests.
  14. If you implement a fix for a reported bug also include a regression test alongside the fix if possible.
  15. When commenting or documenting code make use of proper punctuation. This might seem pedantic but we believe that in essence this is going to improve overall comment and documentation quality.
  16. If possible try to sign your commits, e.g. using GPG keys. For more information about this go here.

Continuous Integration

Our continuous integration (CI) will check for the following properties of all changes.

  1. Does the code still compile?
  2. Is rustfmt happy with it?
  3. Is clippy and all its enabled lints happy with it?
  4. Are tests in debug mode passing?
  5. Are tests in release mode passing?
  6. Is the test code coverage increasing or at least stable?
  7. Is the wasm-32 target still compiling?

Only if our very demanding CI is happy with your pull request we will eventually merge it. Exceptions confirm the rule!

Issues & Pull Requests

Please always respect our code of conduct when writing issues and pull requests or taking part in any kind of discussion.

Issues

You want to write an issue if you have a

  • feature request
  • bug report
  • technical question

about the pDSL.

Please use GitHub's search functionality to see if the question has already been asked, the feature has already been proposed or the bug has already been reported.

Make use of the accompanied issue template.

Pull Requests

Before working on a pull request please make sure that the work has not already been made, e.g. by another pull request solving the same thing.

For complex implementations you are advised to first discuss the feature implementation or bug fix using an issue.

A pull request should be doing or implementing exactly one semantic issue. So for example, when you refactor the code base in a pull request you should not also include code formattings into the same pull request.

For a nice list of hints visit this link.

I don't want to contrubute I just have some questions

For questions about the pDSL project, about Parity Technologies or general technical related questions you are welcome to contact us via Riot. For technical questions specifically about the pDSL and its sub-projects you may also file an issue. For more information about filing issues go here.