You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think you shouldn't abstract the policy in the HWI trait; sign_psbt without specifying what policy you're signing with puts the burden of figuring it out to the library.
But the caller of sign_psbt always knows which policy you're signing with.
if you have multiple inputs with different policies, most likely it's going to be from different signers − so multiple calls to sign_psbt with different policies
sure, one might imagine signing with multiple policies at the same time (if they are all controlled by the same hardware wallet), but I wouldn't bother yet, can generalize in the future
The text was updated successfully, but these errors were encountered:
I defined the interface in a way that it is the simplest and the most common with specter which does not need the policy in the sign_psbt request (Already loaded in specter device memory).
But maybe we should explore other way to do it like for example:
This was reported to me by @bigspider, and i think it makes sense. Copy paste of the report follows.
I think you shouldn't abstract the
policy
in the HWI trait; sign_psbt without specifying what policy you're signing with puts the burden of figuring it out to the library.But the caller of sign_psbt always knows which policy you're signing with.
if you have multiple inputs with different policies, most likely it's going to be from different signers − so multiple calls to sign_psbt with different policies
sure, one might imagine signing with multiple policies at the same time (if they are all controlled by the same hardware wallet), but I wouldn't bother yet, can generalize in the future
The text was updated successfully, but these errors were encountered: