Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onPress is passed to Animated.View while dragging #30

Closed
iremlopsum opened this issue Mar 20, 2017 · 7 comments
Closed

onPress is passed to Animated.View while dragging #30

iremlopsum opened this issue Mar 20, 2017 · 7 comments
Assignees

Comments

@iremlopsum
Copy link

iremlopsum commented Mar 20, 2017

Sliding between Slides still passes an onPress to the child view.

I have a button, and if I drag from it, it gets pressed. Any idea how to solve this reasonably and show that I wouldn't have to handle it on every button separately? To specify, I released the mouse myself and onPressed wasn't passed while I was dragging, but upon release of of drag.

slidingandpress

@talkol
Copy link
Contributor

talkol commented Mar 21, 2017

If I'm not mistaken, this is an Android only issue. also referenced at #31

On iOS it should be working nicely, you can test the following in the example app:
https://github.com/wix/react-native-interactable/blob/master/example/src/TouchesInside.js

@LoyalBlocks-tzachi will work on the touches in Android starting Sunday. If anyone wants to fix them beforehand, we'll appreciate it

@iremlopsum
Copy link
Author

@talkol that's cool. As well I noticed that I can't scroll with in an Animated.View. Seems that interactable is hijacking the event. Does this fall under the same issue?

@talkol
Copy link
Contributor

talkol commented Mar 21, 2017

I think so, I just tested a webview that scrolls in both directions inside an interactable.view and it works well on iOS (it's the same test I linked above)

@Ehesp
Copy link

Ehesp commented Mar 22, 2017

@iremlopsum I raised the scrolling issue here, then saw this issue sorry! #35

@LoyalBlocks-tzachi
Copy link
Contributor

Hi guys! I fixed most of the Android touch issues in this branch: https://github.com/wix/react-native-interactable/tree/androidFixes

I'll appreciate if you can give feedback before I merge to master

The issue that still remains unresolved (I'm still working on it) is horizontal scroll inside horizontal moving interactable (or anything with horizontal drag like a slider)

@talkol
Copy link
Contributor

talkol commented Mar 30, 2017

Merged into master (v0.0.7). Please re-open if the issue is still there. Should be resolved.

@talkol talkol closed this as completed Mar 30, 2017
@victorileaf
Copy link

victorileaf commented Apr 9, 2018

@talkol Hi, Android touch issue is still present in the latest version. can some one help me? Im not getting onPress events Refer: #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants