Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess new pricefeeds reorg #360

Closed
gabaldon opened this issue Jan 2, 2024 · 3 comments
Closed

Assess new pricefeeds reorg #360

gabaldon opened this issue Jan 2, 2024 · 3 comments
Assignees

Comments

@gabaldon
Copy link
Collaborator

gabaldon commented Jan 2, 2024

  • Does the current API model fit the requirements?
  • Define and open issues to cover the requirements
@Tommytrg
Copy link
Member

Tommytrg commented Jan 4, 2024

Some new components need data that is not currently available in the Data Feeds Explorer API, but we can add it with some adjustments.

Last updates component

  • Need a list of the last updated feeds.

We have this information in the database so we can add a new query to the API to be able to retrieve this information.

Feed list component

  • Paginated list of all feeds.
  • Paginated list of feeds filtered by network testnet and name.

To be able to serve this data, we have to split the feedFullName stored in the database into network, mainnet and name fields.

  • Feed sources.

We don't have this information in the database. The easiest way to get it should be by adding it as a constant in the API.

  • All networks in which the feed is deployed.

We need to add this information to the Data Feeds Explorer cache. It can be computed when we get all the price feeds available using https://raw.githubusercontent.com/witnet/data-feeds-explorer/main/packages/api/src/dataFeedsRouter.json.

Stats component

  • Total number of Data Request solved.

Fetch this data using the block Explorer API.

Graph component

  • Get price feed information of all supported chains in the last 7 or 30 days.

We could get this information after splitting the feedFullName field.

Additional suggestions for the Data Feeds Explorer:

@Tommytrg
Copy link
Member

In addition, we should start consuming the new price feed router that allow to query all the price feeds in the network. By doing that, we will reduce the number of calls we make, increasing the performance and saving RPC calls.

We can consume the supportedFeeds method.

The new price feed router could also provide the sources of a data request.

@Tommytrg
Copy link
Member

Issues created from this assessment: #361, #362, #363, #364, #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants