Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider: Should we add additional abstraction or modularity between the oracle and the implementation of the calculator #32

Open
apbendi opened this issue Oct 3, 2024 · 1 comment
Open

Consider: Should we add additional abstraction or modularity between the oracle and the implementation of the calculator #32

apbendi opened this issue Oct 3, 2024 · 1 comment
Labels
pre-audit Needed before the audit deadline todo Issues that need to be tackled pre-audit

Comments

@apbendi
Copy link
Collaborator

apbendi commented Oct 3, 2024

For example, what if we wanted to change the calculator but leave the oracle updates the same, or vice versa.
@apbendi apbendi added todo Issues that need to be tackled pre-audit pre-audit Needed before the audit deadline labels Oct 3, 2024
@garyghayrat
Copy link
Collaborator

This could be useful. I'm imagining a simple contract with a mapping(address delegatee => uint256 score) delegateeScores. But then would we deploy a new contract for each of the DAOs that implement it. Would it make sense then to make it a canonical contract where the Oracle updates scores for delegates in all DAOs like mapping(uint256 DAOIdentifier => address delegatee => uint256 score) delegateeScoresAcrossDaos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pre-audit Needed before the audit deadline todo Issues that need to be tackled pre-audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apbendi @garyghayrat