You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would suggest not catching at all or rethrowing or even returning null to prevent a breaking change and keeping things simple.
Otherwise a new data structure could be used as well, such as a class that contains the path to the image and a status that tells if the capture was successful or not. But that would be a breaking change.
Hi,
Thank you for the plugin first of all.
The line below appears problematic to me as it will return an exception message instead of a file path and the caller won't even be aware of that.
ScreenshotPlugin/src/Screenshot/Screenshot.android.cs
Line 43 in 484d646
I would suggest not catching at all or rethrowing or even returning null to prevent a breaking change and keeping things simple.
Otherwise a new data structure could be used as well, such as a class that contains the path to the image and a status that tells if the capture was successful or not. But that would be a breaking change.
The same problem is present on iOS too:
ScreenshotPlugin/src/Screenshot/Screenshot.apple.cs
Line 25 in 484d646
I am willing to contribute for a fix.
Thanks.
The text was updated successfully, but these errors were encountered: